Bug fix. Change process kill logic back to original logic for Geekbench.#618
Merged
Conversation
42b2518 to
4e2a026
Compare
4e2a026 to
78c5f4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to explicitly kill the Geekbench process was changed to use 'kill -9' command on Linux. Due to an oversight in the property values on an IProcessProxy class after it is disposed, the logic in Geekbench was executing a 'kill -9 0' mistakenly. Passing in a process ID of 0 to the 'kill' command causes the OS to kill not only Geekbench but the Virtual Client application as well. This happens because process information such as the process ID are not available after the process is closed and disposed.
This change reverts the Geekbench logic back to its original state and applies the SafeKill call within side of the IProcessProxy 'using' block instead to ensure it is killed correctly if it does not exit correctly.